Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libeuu: Fix a gtk-doc annotation #231

Merged
merged 1 commit into from Aug 8, 2018
Merged

Conversation

mwleeds
Copy link
Contributor

@mwleeds mwleeds commented Aug 8, 2018

This commit fixes the gtk-doc annotation on the new function
euu_flattened_flatpak_ref_actions_from_paths() so it gets the
element-type correct and specifies (transfer container) instead of
(transfer full). With transfer full, the elements are freed too many
times, because Python tries to free them after freeing the pointer array
(which itself frees them).

This prevents a seg fault when running eos-updater-prepare-volume.

https://phabricator.endlessm.com/T21756

This commit fixes the gtk-doc annotation on the new function
euu_flattened_flatpak_ref_actions_from_paths() so it gets the
element-type correct and specifies (transfer container) instead of
(transfer full). With transfer full, the elements are freed too many
times, because Python tries to free them after freeing the pointer array
(which itself frees them).

This prevents a seg fault when running eos-updater-prepare-volume.

https://phabricator.endlessm.com/T21756
Copy link
Contributor

@pwithnall pwithnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@pwithnall pwithnall merged commit a4d7f08 into master Aug 8, 2018
@pwithnall pwithnall deleted the mwleeds/T21756-gtk-doc-fix branch August 8, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants