Retry network requests on transient errors #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of defaulting to G_IO_ERROR_FAILED, use more specific codes when we can. These were copied from libostree.
Currently if flatpak is installing an extra data app such as Spotify and the server with the .deb file fails to complete the request, the installation fails with a message like "Connection terminated unexpectedly". This commit makes flatpak instead try 5 times to download a given URI if the error returned seems like a transient one (so not, for example, 404 not found). This is analogous to what was done in libostree in commit 938055392fd455027a69398c441b992ae521aa87, and we use some code from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of flatpak/flatpak#3478
https://phabricator.endlessm.com/T29495