power: Do not compute percentage on keyboard disappearing #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the module in charge of the keyboard backlight is rmmod-ed, upower emits a new signal to communicate to gsd that we don't have backlight anymore. This signal is carrying (value == -1, max == 0). In this case we do not want to calculate the new brightness. Signed-off-by: Carlo Caione <carlo@endlessm.com>
wjt
approved these changes
Jan 4, 2018
gnomesysadmins
pushed a commit
to GNOME/gnome-settings-daemon
that referenced
this pull request
Sep 3, 2020
When the module in charge of the keyboard backlight is rmmod-ed, upower emits a new signal to communicate to gsd that we don't have backlight anymore. This signal is carrying (value == -1, max == 0). In this case we do not want to calculate the new brightness. Signed-off-by: Carlo Caione <carlo@endlessm.com> Note 2020-09-03: Based on discussion on the Endless bug tracker, the steps to reproduce this are to unplug a Filco USB keyboard from a Mission One, but perhaps it's applicable on other hardware as well. The original PR for this was endlessm/gnome-settings-daemon#43 - mwleeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T19702