Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Support pitch #26

Merged
merged 2 commits into from Nov 14, 2018
Merged

server: Support pitch #26

merged 2 commits into from Nov 14, 2018

Conversation

cfoch
Copy link
Contributor

@cfoch cfoch commented Nov 12, 2018

@cfoch cfoch requested a review from ptomato November 12, 2018 18:08
ptomato
ptomato approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you have to rebuild gstreamer-plugins-bad because the version of it distributed in the runtime does not have the soundtouch library?
Is there any way to build only the soundtouch plugins, so we don't have to rebuild the whole thing and risk having hard-to-track-down bugs because our versions of the plugins are subtly different?

If that's not possible, then feel free to merge this.

@cfoch
Copy link
Contributor Author

cfoch commented Nov 13, 2018

I think it is possible, but I am not sure yet why this is not working as expected. The combination of --auto-features=disabled and -Dsoundtouch=enabled should make the trick, but for some reason it starts to compile libraries from gst-libs. I am using the same package that the platform is using, btw.

@ptomato
Copy link
Contributor

ptomato commented Nov 13, 2018

Do you feel like you are close to an improvement, or should we just merge this as-is anyway and open an issue to fix the duplication later? Time is short.

@cfoch
Copy link
Contributor Author

cfoch commented Nov 14, 2018 •
edited

I don't think I will be able to do it today. It should be merged. Anyway, I am using the same version used in the used Sdk.

@ptomato
build: Cleanup extra GStreamer stuff
c813771 
We only want to build the soundtouch plugin and don't want to run the
risk of GStreamer finding any other copies of libraries that may have
been built with different options. Mixing GStreamer installations has
caused hard-to-track-down crashes in the past.

https://phabricator.endlessm.com/T24386
@ptomato ptomato merged commit d92c86f into master Nov 14, 2018
@ptomato ptomato deleted the pitch branch November 14, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cfoch @ptomato