-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get collections from the latest release #152
base: develop
Are you sure you want to change the base?
Conversation
e9e96f1
to
8512ff6
Compare
Instead of downloading collections from the newest commit, use the most recent release from endless-key-collections.
8512ff6
to
e41b2a3
Compare
bot test |
Fixes commit e41b2a3 ("Get collections from the latest release").
It can get the correct URL for But, there comes another error:
|
Fixed by commit ("fixup! Get collections from the latest release") |
@dylanmccall Please help review the modification again :) |
Given that the collection JSON files are now published at https://endlessm.github.io/endless-key-collections, I think we should just wait until the explore plugin is fetching them at runtime and use #150 instead of adding more code for this intermediate state. |
Ah, thank you for fixing those errors @starnight! Yeah, the reason for this change is to get a workflow in place for versioning endless-key-collections in order limit the amount of stuff that changes from endlessm/kolibri-explore-plugin#610. That's because I don't think we should release that explore plugin change until July. But if you're happy with what we have for the time being, I'm fine with that too - feel free to close this, and we can revert endlessm/endless-key-app#124 to keep things consistent :) |
Instead of downloading collections from the newest commit, use the most recent release from endless-key-collections.
endlessm/kolibri-explore-plugin#610