Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get collections from the latest release #152

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dylanmccall
Copy link

@dylanmccall dylanmccall commented Jun 15, 2023

Instead of downloading collections from the newest commit, use the most recent release from endless-key-collections.

endlessm/kolibri-explore-plugin#610

Instead of downloading collections from the newest commit, use the most
recent release from endless-key-collections.
@dylanmccall dylanmccall marked this pull request as ready for review June 20, 2023 01:37
@starnight
Copy link

bot test

Makefile Show resolved Hide resolved
Fixes commit e41b2a3 ("Get collections from the latest release").
@starnight
Copy link

It can get the correct URL for COLLECTIONS_TARBALL_URL.

But, there comes another error:

Saving to: 'collections.tar.gz'

     0K .......... .......... .......                          3.77M=0.007s

2023-06-20 06:42:54 (3.77 MB/s) - 'collections.tar.gz' saved [27726]

mkdir -p src/collections
tar -xz -f collections.tar.gz -C src/collections --overwrite '*/json/*.json' --strip-components=2
tar: Pattern matching characters used in file names
tar: Use --wildcards to enable pattern matching, or --no-wildcards to suppress this warning
tar: */json/*.json: Not found in archive
tar: Exiting with failure status due to previous errors

@starnight
Copy link

starnight commented Jun 20, 2023

Fixed by commit ("fixup! Get collections from the latest release")

@starnight
Copy link

starnight commented Jun 20, 2023

@dylanmccall Please help review the modification again :)

@starnight starnight self-requested a review June 20, 2023 13:37
@dbnicholson
Copy link
Member

Given that the collection JSON files are now published at https://endlessm.github.io/endless-key-collections, I think we should just wait until the explore plugin is fetching them at runtime and use #150 instead of adding more code for this intermediate state.

@dylanmccall
Copy link
Author

dylanmccall commented Jun 20, 2023

Ah, thank you for fixing those errors @starnight! Yeah, the reason for this change is to get a workflow in place for versioning endless-key-collections in order limit the amount of stuff that changes from endlessm/kolibri-explore-plugin#610. That's because I don't think we should release that explore plugin change until July. But if you're happy with what we have for the time being, I'm fine with that too - feel free to close this, and we can revert endlessm/endless-key-app#124 to keep things consistent :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants