Webview: Drop USB APIs relating to Welcome screen #175
Conversation
starnight
force-pushed
the
drop-USB-API
branch
from
e40833d
to
c693b49
Compare
There was a problem hiding this comment.
Looks good. There's also all the kolibri_whitenoise hacking that becomes unnecessary after this, but we can do that as a followup. I did a quick test run and it got to the download page.
I think you can delete everything to do with android_utils.get_endless_key_uris, StartupState.USB_USER and KOLIBRI_CONTENT_FALLBACK_DIRS.
Since the commit ("Welcome: Drop USB/SD option from Welcome screen") of
kolibri-explore-plugin [1] drops the USB option, Endless Key app removes
corresponding USB APIs accordingly.
[1]: https://github.com/endlessm/kolibri-explore-plugin
Fixes: #171
starnight
force-pushed
the
drop-USB-API
branch
from
c693b49
to
02cf345
Compare
|
Drop |
This reverts commit 7d3d57c. We no longer need any DocumentsProvider support if we're not trying to access a directory on a USB drive.
There was a problem hiding this comment.
This looks good to me and ran correctly in my testing. I added one more revert to completely remove the DocumentsProvider support. We don't have any more use for that. @dylanmccall wanted to take a look at this, so I'm adding him as a reviewer.
|
Tested by the comment #171 (comment) |
Since the commit ("Welcome: Drop USB/SD option from Welcome screen") of kolibri-explore-plugin 1 drops the USB option, Endless Key app removes corresponding USB APIs accordingly.
Fixes: #171