Material Light theme with black status bar #176
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default python-for-android appends `.Fullscreen` to the theme. On ChromeOS this has no effect, but on Android it makes the app cover the status bar. I don't believe Endless Key is so important that it needs that and it introduces a difference with ChromeOS where the app always runs windowed and the status bar color is used for the window decoration. Add the p4a `--window` option so that it doesn't append `.Fullscreen` to the theme.
This restores the attempt to use Material Light except that it overrides the status bar to black as the previous theme did. A custom theme using a resource value file is needed for that. This depends on the new `--res-values` option in python-for-android v2022.09.04-endless11. Fixes: #174
|
retest this please |
|
The p4a PR mas merged and tagged as |
|
We discussed in the team meeting today that it would be preferable not to touch the appearance anymore right now before we take a break from this work. I'm going to move this back to a draft so it doesn't get merged right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try again with Material Light but use a custom derived theme that restores the status bar to black. This also uncovers the status bar on pure Android by using a non-Fullscreen theme. That has no effect on ChromeOS but is more reasonable on Android and makes it easier to validate the theme.
This depends on endlessm/python-for-android#19 being merged and released. Marking as a draft until that happens.
Fixes: #174