Skip to content

Commit

Permalink
Assume errors are fatal iff we show no recover button
Browse files Browse the repository at this point in the history
This means we don't have to remember to update this switch when we add new
recoverable errors.

I don't really look at the exceptionTracking data but since it's here...
  • Loading branch information
wjt committed Oct 25, 2017
1 parent a015809 commit 70d653d
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions src/endless/EndlessUsbToolDlg.cpp
Expand Up @@ -1898,17 +1898,7 @@ void CEndlessUsbToolDlg::ErrorOccured(ErrorCause_t errorCause)
else
TrackEvent(_T("Failed"), ErrorCauseToStr(errorCause));

bool fatal = FALSE;
switch (errorCause) {
case ErrorCause_t::ErrorCauseDownloadFailed:
case ErrorCause_t::ErrorCauseVerificationFailed:
case ErrorCause_t::ErrorCauseWriteFailed:
fatal = FALSE;
break;
default:
fatal = TRUE;
break;
}
bool fatal = recoverButtonMsgId == 0;
Analytics::instance()->exceptionTracking(ErrorCauseToStr(errorCause), fatal);
}

Expand Down

0 comments on commit 70d653d

Please sign in to comment.