[release_table] Simplify header and row selection #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change headers_selector to header_selector: there was no need to ask the header cell selection, so updated it to match rows selection. - Set header_selector default value to 'thead tr'. - Set rows_selector default value to 'tbody tr'.
|
No update detected, LGTM. Merging. |
marcwrobel
added a commit
to endoflife-date/endoflife.date
that referenced
this pull request
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
headers_selectortoheader_selector: there was no need to ask the header cell selection, so updated it to match rows selection.header_selectordefault value tothead tr.rows_selectordefault value totbody tr.