build: automatically build types in prepack (#2258)

refs: #1488 

## Description

Simplify build by using NPM lifecycle hooks. Adds a CI test for the
package graph sensitivity that the extant method was checking.

Part of making it work was adding "typescript" to `devDependencies` of
packages that need it. The root `build:types` was running with the root
`tsc` but when building in each package separately they wouldn't get the
root's typescript version and fall back to the global one, which didn't
know the `@import` syntax.


### Security Considerations

None

### Scaling Considerations

None

### Documentation Considerations

Less to document 

### Testing Considerations

I tried the "publish" commands in CONTRIBUTING.md. 

integration PR in agoric-sdk:
Agoric/agoric-sdk#9385

### Compatibility Considerations

Removes a necessary accommodation on agoric-sdk

### Upgrade Considerations

None

.github/workflows/ci.yml

@@ -318,12 +318,14 @@ jobs:
       - name: build
         run: yarn run build
 
-      - name: build:types
-        run: yarn lerna run build:types
-
       - name: pack
         # Cannot use yarn lerna run pack
         run: yarn lerna exec yarn pack
 
-      - name: clean:types
-        run: yarn lerna run clean:types
+      # Prepack (without cleanup per package) to ensure that type resolution in
+      # dependent packages continues to work when the typedefs are generated by
+      # their upstream packages. This helps avoid a situation in which the types
+      # only resolve because of the state of the local filesystem, and fails
+      # when imported in an NPM node_modules tree.
+      - name: Prepack packages
+        run: yarn lerna run --reject-cycles --concurrency 1 prepack

CONTRIBUTING.md

@@ -106,23 +106,6 @@ https://github.com/endojs/endo/labels/next-release
   yarn build
   ```
 
-* Generate types.
-
-  ```sh
-  yarn lerna run build:types
-  ```
-
-  We generate types from the bottom up before publishing because this allows
-  each package to rely on the generated types of its dependencies in the
-  workspace.
-
-* Commit the generated types.
-
-  ```sh
-  git add .
-  git commit -m 'chore: Add generated types'
-  ```
-
 * Recreate the changelogs with the current date *and* generate tags for the new
   versions. This is the effect of removing the `--no-git-tag-version` flag.
 
@@ -161,18 +144,6 @@ https://github.com/endojs/endo/labels/next-release
   npm view ses
   ```
 
-* Revert the change that added generated types.
-
-  ```sh
-  git revert HEAD^
-  ```
-
-  This command should then efect no changes.
-
-  ```sh
-  yarn lerna run clean:types
-  ```
-
 * Force push these changes back to the pull request branch.
 
   ```sh

packages/base64/package.json

@@ -32,8 +32,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "cover": "c8 ava",
     "lint": "yarn lint:types && yarn lint:eslint",
     "lint-fix": "eslint --fix .",

packages/bundle-source/package.json

@@ -13,8 +13,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
@@ -40,7 +40,8 @@
     "@endo/lockdown": "^1.0.7",
     "@endo/ses-ava": "^1.2.2",
     "ava": "^6.1.2",
-    "c8": "^7.14.0"
+    "c8": "^7.14.0",
+    "typescript": "5.5.0-beta"
   },
   "keywords": [],
   "files": [

packages/captp/package.json

@@ -35,8 +35,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
@@ -50,7 +50,8 @@
     "@endo/init": "^1.1.2",
     "@endo/ses-ava": "^1.2.2",
     "ava": "^6.1.2",
-    "c8": "^7.14.0"
+    "c8": "^7.14.0",
+    "typescript": "5.5.0-beta"
   },
   "dependencies": {
     "@endo/errors": "^1.2.2",

packages/check-bundle/package.json

@@ -30,8 +30,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "lint": "yarn lint:types && yarn lint:eslint",
     "lint-fix": "eslint --fix .",
     "lint:eslint": "eslint .",

packages/cjs-module-analyzer/package.json

@@ -22,8 +22,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "cover": "c8 ava",
     "lint": "yarn lint:types && yarn lint:eslint",
     "lint-fix": "eslint --fix .",

packages/cli/package.json

@@ -22,8 +22,8 @@
   "exports": {},
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "lint": "yarn lint:types && yarn lint:eslint",
     "lint-fix": "eslint --fix .",
     "lint:eslint": "eslint .",

packages/common/package.json

@@ -29,8 +29,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "lint": "yarn lint:types && yarn lint:eslint",
     "lint-check": "yarn lint",
     "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
@@ -50,7 +50,8 @@
     "@endo/ses-ava": "^1.2.2",
     "ava": "^6.1.2",
     "c8": "^7.14.0",
-    "tsd": "^0.30.7"
+    "tsd": "^0.30.7",
+    "typescript": "5.5.0-beta"
   },
   "files": [
     "*.js",

packages/compartment-mapper/package.json

@@ -36,8 +36,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "cover": "c8 ava",
     "lint": "yarn lint:types && yarn lint:eslint",
     "lint-fix": "eslint --fix .",

packages/daemon/package.json

@@ -33,8 +33,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "cover": "c8 ava",
     "lint": "yarn lint:types && yarn lint:eslint",
     "lint-fix": "eslint --fix .",

packages/env-options/package.json

@@ -29,8 +29,8 @@
     "lint-fix": "eslint --fix .",
     "lint:eslint": "eslint .",
     "lint:types": "tsc",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "test": "exit 0"
   },
   "devDependencies": {

packages/errors/package.json

@@ -29,8 +29,8 @@
     "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
     "lint:eslint": "eslint '**/*.js'",
     "lint:types": "tsc",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0"
@@ -44,7 +44,8 @@
     "ava": "^6.1.2",
     "c8": "^7.14.0",
     "ses0_18_3": "npm:ses@0.18.3",
-    "tsd": "^0.30.7"
+    "tsd": "^0.30.7",
+    "typescript": "5.5.0-beta"
   },
   "files": [
     "*.js",

packages/evasive-transform/package.json

@@ -29,8 +29,8 @@
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
     "lint-check": "yarn lint",
     "lint": "yarn lint:types && yarn lint:eslint",

packages/eventual-send/package.json

@@ -10,8 +10,8 @@
     "test:xs": "exit 0",
     "build": "exit 0",
     "clean": "git clean -f '*.d.ts*'",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
     "lint-check": "yarn lint",
     "lint": "yarn lint:types && yarn lint:eslint",
@@ -42,7 +42,8 @@
     "@endo/lockdown": "^1.0.7",
     "ava": "^6.1.2",
     "c8": "^7.14.0",
-    "tsd": "^0.30.7"
+    "tsd": "^0.30.7",
+    "typescript": "5.5.0-beta"
   },
   "keywords": [
     "eventual send",

packages/exo/package.json

@@ -24,8 +24,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "lint": "yarn lint:types && yarn lint:eslint",
     "lint-fix": "eslint --fix .",
     "lint:eslint": "eslint .",

packages/far/package.json

@@ -13,8 +13,8 @@
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
     "lint-check": "yarn lint",
     "lint": "yarn lint:types && yarn lint:eslint",
@@ -41,7 +41,8 @@
     "@endo/init": "^1.1.2",
     "@endo/ses-ava": "^1.2.2",
     "ava": "^6.1.2",
-    "c8": "^7.14.0"
+    "c8": "^7.14.0",
+    "typescript": "5.5.0-beta"
   },
   "keywords": [
     "eventual send",

packages/import-bundle/package.json

@@ -31,8 +31,8 @@
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "lint-fix": "eslint --fix '**/*.js'",
     "lint": "yarn lint:types && yarn lint:eslint",
     "lint:eslint": "eslint .",
@@ -50,7 +50,8 @@
     "@endo/init": "^1.1.2",
     "@endo/ses-ava": "^1.2.2",
     "ava": "^6.1.2",
-    "c8": "^7.14.0"
+    "c8": "^7.14.0",
+    "typescript": "5.5.0-beta"
   },
   "files": [
     "LICENSE*",

packages/init/package.json

@@ -19,8 +19,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "test": "ava",
     "test:xs": "exit 0",
     "lint-check": "yarn lint",
@@ -30,7 +30,8 @@
   },
   "devDependencies": {
     "@endo/compartment-mapper": "^1.1.5",
-    "ava": "^6.1.2"
+    "ava": "^6.1.2",
+    "typescript": "5.5.0-beta"
   },
   "dependencies": {
     "@endo/base64": "^1.0.5",

packages/lp32/package.json

@@ -40,8 +40,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "cover": "c8 ava",
     "lint": "yarn lint:types && yarn lint:eslint",
     "lint-fix": "eslint --fix .",

packages/marshal/package.json

@@ -13,8 +13,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "test": "ava",
     "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js",
     "test:xs": "exit 0",
@@ -54,7 +54,8 @@
     "@endo/ses-ava": "^1.2.2",
     "@fast-check/ava": "^1.1.5",
     "ava": "^6.1.2",
-    "c8": "^7.14.0"
+    "c8": "^7.14.0",
+    "typescript": "5.5.0-beta"
   },
   "files": [
     "LICENSE*",

packages/memoize/package.json

@@ -29,8 +29,8 @@
     "lint-fix": "eslint --fix .",
     "lint:eslint": "eslint .",
     "lint:types": "tsc",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "test": "ava"
   },
   "dependencies": {

packages/nat/package.json

@@ -10,8 +10,8 @@
   },
   "scripts": {
     "build": "exit 0",
-    "build:types": "tsc --build tsconfig.build.json",
-    "clean:types": "git clean -f '*.d.ts*'",
+    "prepack": "tsc --build tsconfig.build.json",
+    "postpack": "git clean -f '*.d.ts*'",
     "lint": "yarn lint:types && yarn lint:eslint",
     "lint-fix": "eslint --fix .",
     "lint:eslint": "eslint .",
@@ -37,7 +37,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-import": "^2.29.0",
     "prettier": "^3.2.5",
-    "ses": "^1.5.0"
+    "ses": "^1.5.0",
+    "typescript": "5.5.0-beta"
   },
   "directories": {
     "test": "test"