refactor: use @endo/errors when acyclic #2324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staged on #2323
Closes: #XXXX
Refs: Agoric/agoric-sdk#5672 Agoric/agoric-sdk#9513
Description
Does for endo what Agoric/agoric-sdk#9513 does for agoric-sdk --- importing
assert
from @endo/errors --- when it can do so without causing dependency cycles. For the remaining packages that would cause dependency cycles, just move them towards more modern assert conventions while still using the unstructured globalassert
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
We should document
assert
only as imported from @endo/errors, since our users will not generally contribute code within endo's internal dependency cycles.Testing Considerations
The CI run on this PR also serves to test #2323, since that one, by itself, does not cause a behavioral change. It's purpose is to enable this PR not to hit the problem described at Agoric/agoric-sdk#9515
Compatibility Considerations
none
Upgrade Considerations
none