fix(ses)!: Simplify transforms #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kris/simplify-transforms
branch
from
8547754
to
5bd14aa
Compare
This change simplifies the compartment transforms for evaluated programs to just an array of functions that accept and return program strings. The previous version of this API enabled transforms to add endowments and left room for future transformable properties. We have elected to use the compartment `evaluate` function to introduce lexical endowments and `globalThis` to introduce enumerable and computable endowments.
kriskowal
force-pushed
the
kris/simplify-transforms
branch
from
5bd14aa
to
3e55230
Compare
erights
approved these changes
May 21, 2020
| @@ -95,6 +95,7 @@ export function rejectImportExpressions(src) { | |||
|
|
|||
| const someDirectEvalPattern = new RegExp('\\beval\\s*(?:\\(|/[/*])'); | |||
|
|
|||
| // Exported for unit tests. | |||
There was a problem hiding this comment.
Thanks for noting that.
For all these, what is needed so that the error here could carry more context that just the line number? (not suggesting any such change for this PR though.)
There was a problem hiding this comment.
We could change the non-capture group for the body of the eval expression in the regular expression to a capture-group and report that. I imagine that could get quite unwieldy depending on the length of the expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the compartment transforms for evaluated programs to just an array of functions that accept and return program strings. The previous version of this API enabled transforms to add endowments and left room for future transformable properties. We have elected to use the compartment
evaluatefunction to introduce lexical endowments andglobalThisto introduce enumerable and computable endowments.Fixes #321