fix: remove deprecated noTame options #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this needs to wait for anything from agoric-sdk.. we've got semver, as long as it's marked as a breaking change, whatever version agoric-sdk is using will continue to work the same way as before, and when agoric-sdk upgrades to the new version, the same PR must also make the matching invocation changes. (incidentally, agoric-sdk trunk is still using the old 0.6.5 SES, so the only branch that uses |
kriskowal
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326
Removes support for old noTame options, which we can't merge until after Agoric/agoric-sdk#1128 is merged.
As described in #326, subsequent calls to
lockdowndon't need to agree exactly. Only the options provided need to agree exactly. Absence implies agreement with the status quo, whatever that is.