fix: remove extra stackframe #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
When we make an error by calling
newon either of our replacementErrorconstructors, it calls the originalErrorconstructor to make the error. Thus, the replacementErrorconstructor is on the stack above the creation of the new error object. This is exactly the problem that v8 designedError.captureStackTraceto solve, and we solve it using their suggested pattern. The price of this pattern is that the stack trace is reified into a structured-stack-trace (sst) immediately rather than on demand. However, rendering the sst as a string is still on demand as intended.