Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consolidate honorary native function printing #392

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Conversation

erights
Copy link
Contributor

@erights erights commented Jul 24, 2020

Rather than add a bunch of add hoc toString methods to try to make shimmed methods appear native, instead tame Function.prototype.toString to do a brand check on whether a function is an honorary native function. Have the whitelisting machinery apply this brand to every surviving function encountered during whitelisting.

@erights erights merged commit 038bb13 into master Jul 24, 2020
@erights erights deleted the native-tostring branch July 24, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants