Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint rule to suppress bogus dependency warning #483

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

erights
Copy link
Contributor

@erights erights commented Oct 2, 2020

In keybase @katelynsills said:

Btw, the way to turn off the annoying red squigglies in tests when they tell you something you import should be a real dependency is this ESLint setting:

"import/no-extraneous-dependencies": [
        "error",
        {
          "devDependencies": true
        }
      ]

This PR does that.

Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erights erights merged commit 7e3d9ea into master Oct 2, 2020
@erights erights deleted the dev-dependencies-ok branch October 2, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants