feat(ses): Censorship error messages may now contain the source name #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Nov 10, 2020
packages/ses/src/transforms.js
Outdated
| const linenum = getLineNumber(src, importPattern); | ||
| if (linenum < 0) { | ||
| return src; | ||
| } | ||
| throw new SyntaxError( | ||
| `possible import expression rejected around line ${linenum}`, | ||
| `possible import expression rejected around line ${linenum} of ${name}`, |
packages/ses/src/transforms.js
Outdated
| const linenum = getLineNumber(src, someDirectEvalPattern); | ||
| if (linenum < 0) { | ||
| return src; | ||
| } | ||
| throw new SyntaxError( | ||
| `possible direct eval expression rejected around line ${linenum}`, | ||
| `possible direct eval expression rejected around line ${linenum} of ${name}`, |
| { | ||
| name: 'SyntaxError', | ||
| message: | ||
| 'possible direct eval expression rejected around line 1 of <unknown>', |
kriskowal
force-pushed
the
kris-evaluate-name
branch
from
fd906c4
to
5850933
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should permit a more graceful debugging experience for censorship errors.