Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add "name" to moderate overrideTaming of all errors #867

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

erights
Copy link
Contributor

@erights erights commented Aug 24, 2021

No description provided.

@erights erights self-assigned this Aug 24, 2021
@kriskowal
Copy link
Member

We could test this, either directly or by inducing Node.js to attempt to create an error, but if you're satisfied that the existing feature tests cover the behavior, I have no argument.

@kriskowal
Copy link
Member

We could also leave a note in NEWS.md.

@erights erights merged commit d608325 into master Aug 24, 2021
@erights erights deleted the markm-node-14-error-shenanigans branch August 24, 2021 21:25
@erights
Copy link
Contributor Author

erights commented Aug 24, 2021

Sorry, I missed the NEWS.md comment. I'll do that now.

@erights
Copy link
Contributor Author

erights commented Aug 24, 2021

Actually, while do that, could you put an issue somewhere, anywhere I can point at, explaining the anomalous Node behavior, with that code snippet, so I can cite that bug in my NEWS.md note? Thanks.

@kriskowal
Copy link
Member

kriskowal commented Aug 24, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants