accept require.resolve implementation as option to importLocation et al.

[naugtur]

Receiving the implementation externally makes more sense than supporting require.resolve functionality endoEndo.

This PR accepts the implementation and, if not provided, defaults to a similar error Node would throw.

[naugtur]

I like how easy it is to provide the implementation.
A more secure implementation would use options.paths to limit the search space and guard return values by checking with String.startsWiththat it's not reaching beyond the project folder.

A cache lookup of known needed paths for specifiers is also an option.

[kriskowal]

I would like to fold requireResolve into the optional properties of readPowers. Otherwise, this looks good to me.

[naugtur]

Now all that's left to do is convince Typescript I can call this function if I check the field exists even thought it's optional on readPowers

[naugtur]

it stopped complaining when I did this

 if (typeof readPowers === 'object' && readPowers.requireResolve) {
    const { requireResolve } = readPowers;
    require.resolve = freeze((specifier, options) =>
      requireResolve(location, specifier, options),
    );

I don't appreciate what TS is trying to do for me here

[mhofman]

I'm not sure I have much context to review this PR. Is there anything specific you'd like me to take a look at?

[naugtur]

I'm not sure I have much context to review this PR. Is there anything specific you'd like me to take a look at?

@mhofman Automatons said you had overlap with the codebase that this touches. All I'm looking for is a skim and a veto if I did something you consider harmful.

[naugtur]

@kriskowal This is ready IMHO, I need the final review.

[mhofman]

@mhofman Automatons said you had overlap with the codebase that this touches

Automatons are mistaken, I'll remove myself as reviewer.

[kriskowal]

Is this envelope still necessary?

[naugtur]

While not necessary, it's likely to save some people a bunch of time I lost when adding more items to parse arguments and wondering why they're not getting passed to the parseCjs function because it's wrapped along the way.
I'd like to keep it.