Implement providing the url value in import.meta #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naugtur
commented
Jun 2, 2022
naugtur
force-pushed
the
naugtur-import-meta-url
branch
from
f8f8de1
to
3b5d364
Compare
naugtur
force-pushed
the
naugtur-import-meta-url-value
branch
from
f969026
to
c12ec20
Compare
naugtur
force-pushed
the
naugtur-import-meta-url
branch
from
3b5d364
to
c176b04
Compare
naugtur
force-pushed
the
naugtur-import-meta-url-value
branch
2 times, most recently
from
825c94f
to
f5f9ef7
Compare
naugtur
commented
Jun 7, 2022
kriskowal
reviewed
Jun 7, 2022
naugtur
force-pushed
the
naugtur-import-meta-url
branch
4 times, most recently
from
47eefca
to
b7cd6e7
Compare
|
|
naugtur
force-pushed
the
naugtur-import-meta-url-value
branch
from
f5f9ef7
to
17e1a60
Compare
naugtur
commented
Jun 15, 2022
| @@ -67,6 +67,7 @@ export type FinalStaticModuleType = | |||
| export interface RedirectStaticModuleInterface { | |||
| record: FinalStaticModuleType; | |||
| specifier: string; | |||
| importMeta?: any; | |||
| } | |||
|
|
|||
| export type StaticModuleType = | |||
There was a problem hiding this comment.
This part will need a rewrite to match current spec. That's going to happen alongside a wider rewrite to match shapes defined in the compartment proposal later.
naugtur
force-pushed
the
naugtur-import-meta-url-value
branch
from
17e1a60
to
9b29a9c
Compare
naugtur
commented
Jun 22, 2022
naugtur
force-pushed
the
naugtur-import-meta-url-value
branch
from
a0933cd
to
dccb967
Compare
|
@kriskowal All done, I need a rubber stamp. |
naugtur
force-pushed
the
naugtur-import-meta-url-value
branch
from
dccb967
to
9dd5c12
Compare
kriskowal
approved these changes
Jun 24, 2022
packages/compartment-mapper/test/fixtures-0/node_modules/app/main.js
Outdated
Show resolved
Hide resolved
naugtur
force-pushed
the
naugtur-import-meta-url-value
branch
from
9dd5c12
to
bfb537f
Compare
naugtur
force-pushed
the
naugtur-import-meta-url-value
branch
from
bfb537f
to
d6294f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented meta.url via module descriptors.
Bundler complained, but I think I've fixed it correctly.