feat(ses): anticipate iterator helpers #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
commented
Jun 28, 2023
erights
changed the title
erights
force-pushed
the
markm-1289-anticipate-iteration-helpers
branch
5 times, most recently
from
e720250
to
d200cf6
Compare
|
Earlier I wrote
Both are now done. This is Ready for Review. |
mhofman
reviewed
Jul 5, 2023
kriskowal
approved these changes
Jul 6, 2023
erights
force-pushed
the
markm-1289-anticipate-iteration-helpers
branch
from
d200cf6
to
b0b28a2
Compare
This was referenced Jul 6, 2023
zloirock
reviewed
Jul 6, 2023
| // core-js iterator shim. | ||
| // We mutate the permits to tolerates the sloppy functions for testing | ||
| // by sacrificing security. The caller and arguments properties of | ||
| // sloppy functions violate ocap encapsulation rules. |
There was a problem hiding this comment.
core-js use strict mode, but, for modules size economy, not in all cases - for example, in cases where this depends on it. I didn't think that .arguments and .caller are interesting to anyone. I can consider adding the strict mode in all affected cases. You could open an issue in the core-js repo.
There was a problem hiding this comment.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1289
Anticipate both Iterator Helpers and Async Iterator Helpers.
Note that Iterator Helpers are already as stage 3, so we can expect engines to start shipping these at any time.
Reviewers, please check it against the text of the proposals.