test(ses): fix 1973, unskip log test #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-1973-tolerate-extra-warnings
branch
from
71da02a
to
4baea6f
Compare
dckc
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1973
refs: #XXXX
Description
Previously,
throwsAndLogswould only support testing against a literal golden. But for testing the initial-removal-log-messages, this was too fragile, since new engines might have added new properties whose removal would general additional initial-removal-log-messages. This PR enable the caller to provide an alternative compare function. That one test then uses this flexibility to tolerate additional warnings interspersed between the golden warnings it looks for.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
The whole point. This enables us to turn an annoying
test.skipback into the neededtest.Compatibility Considerations
Enables the test to remain compatible with benign future engine versions.
Upgrade Considerations
none.
Nothing breaking.
No news updates warranted.
*BREAKING*:in the commit message with migration instructions for any breaking change.NEWS.mdfor user-facing changes.