Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to ava ^6 #2144

Merged
merged 5 commits into from
Mar 14, 2024
Merged

chore: Upgrade to ava ^6 #2144

merged 5 commits into from
Mar 14, 2024

Conversation

kriskowal
Copy link
Member

@kriskowal kriskowal commented Mar 14, 2024

Progresses: #2125

@kriskowal
Copy link
Member Author

@turadg This is a wholesale upgrade to ava@^6 in endo and it looks great except there appears to be a bad interaction between ses, execa, and the new ava. I’m investigating this now.

    ℹ REJECTED from ava test("bundle-source command is concurrency safe"): (TypeError#1)
    ℹ TypeError#1: Invalid property descriptor. Cannot both specify accessors and a value or writable attribute, [object Object]
    ℹ   at InertConstructor.defineProperty (<anonymous>)
        at Object.expect (packages/bundle-source/test/execava.js:9:43)
        at packages/bundle-source/test/test-tool-command.js:12:104
        at Array.map (<anonymous>)
        at packages/bundle-source/test/test-tool-command.js:11:52
        at logErrorFirst (packages/ses-ava/src/ses-ava-test.js:96:14)
        at wrappedFunc (packages/ses-ava/src/ses-ava-test.js:216:16)
        at async Promise.all (index 0)

@kriskowal
Copy link
Member Author

kriskowal commented Mar 14, 2024

@turadg This is a wholesale upgrade to ava@^6 in endo and it looks great except there appears to be a bad interaction between ses, execa, and the new ava. I’m investigating this now.

Root cause of this is in mimic-fn, retained by onetime, retained by execava, which does a hasty toString patch which does not compose well with our “enablements” on toString (replacing the value with a get descriptor). I’ve pushed a patch and seek to get it upstream. sindresorhus/mimic-function#51

@kriskowal kriskowal marked this pull request as ready for review March 14, 2024 04:26
@kriskowal kriskowal requested a review from turadg March 14, 2024 04:26
Copy link
Contributor

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving to your discretion when to drop the patch (since your sindresorhus/mimic-function#51 is released in https://www.npmjs.com/package/mimic-function/v/5.0.1 )

@kriskowal
Copy link
Member Author

LGTM. Leaving to your discretion when to drop the patch (since your sindresorhus/mimic-function#51 is released in https://www.npmjs.com/package/mimic-function/v/5.0.1 )

Wow, we’ve never gotten one of these upstreamed overnight.

@kriskowal kriskowal merged commit 9dd5e27 into master Mar 14, 2024
18 checks passed
@kriskowal kriskowal deleted the kriskowal-ava-6 branch March 14, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants