-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Expand options for storing values #2237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e17e3bf
to
e579680
Compare
af51844
to
b22dfc3
Compare
e579680
to
5f8e045
Compare
b22dfc3
to
9bbbd45
Compare
5f8e045
to
4e62d42
Compare
9bbbd45
to
2f8803c
Compare
rekmarks
reviewed
Apr 24, 2024
This comment was marked as resolved.
This comment was marked as resolved.
4e62d42
to
e64b92a
Compare
2f8803c
to
7177dc1
Compare
e64b92a
to
b0b7a43
Compare
7177dc1
to
576bb17
Compare
b0b7a43
to
91b3324
Compare
576bb17
to
5171331
Compare
91b3324
to
b5b6aeb
Compare
5171331
to
fa4d4ee
Compare
rekmarks
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion to DRY up store.js
, otherwise LGTM.
fa4d4ee
to
a909df8
Compare
b5b6aeb
to
a4a53d0
Compare
a909df8
to
0eb8759
Compare
rekmarks
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In, #2226 we gain the ability to marshal copy data and remotables that are backed by formulas.
This change surfaces these features to the CLI by exposing a variety of flags.