Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make pull request template guidance more evident if it persists #2271

Merged
merged 1 commit into from
May 7, 2024

Conversation

kriskowal
Copy link
Member

The pull request template currently leaves invisible comments which have occasionally survived into commit messages. This changes those comments to block quotes to make their existence more evident to reviewers and to encourage change proposers to delete them as they fill the form.

@kriskowal kriskowal requested review from turadg and erights May 6, 2024 21:50
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kriskowal kriskowal merged commit 5ad0e7e into master May 7, 2024
17 checks passed
@kriskowal kriskowal deleted the kriskowal-leave-no-trace branch May 7, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants