docs(patterns): Comments for fixed-length heterogeneous collection patterns #2291
Conversation
kriskowal
force-pushed
the
kriskowal-patterns-struct
branch
from
420ba6e
to
58dec29
Compare
kriskowal
force-pushed
the
kriskowal-patterns-struct
branch
4 times, most recently
from
7ff741e
to
72e6090
Compare
| @@ -1651,13 +1651,26 @@ const makePatternKit = () => { | |||
| limits ? makeLimitsMatcher('match:symbol', [limits]) : SymbolShape, | |||
| record: (limits = undefined) => | |||
| limits ? M.recordOf(M.any(), M.any(), limits) : RecordShape, | |||
| // The pattern for a CopyRecord with a fixed quantity of heterogeneous | |||
| // entry types (a Struct) is merely a hardened object with the respective | |||
There was a problem hiding this comment.
Shouldn't this be
| // entry types (a Struct) is merely a hardened object with the respective | |
| // value types (a Struct) is merely a hardened object with the respective |
Also, I'm uncomfortable making the connection to types in a way that sound stronger than just a metaphor. TS types are both more and less expressive than patterns. Neither is a subset of the other.
| // entry types (a Struct) is merely a hardened object with the respective | |
| // value patterns (a Struct) is merely a hardened object with the respective |
That "hardened object" is itself a CopyRecord btw. Put more simply, a CopyRecord whose property values are patterns is itself a pattern. I don't know if this helps.
There was a problem hiding this comment.
I rewrote all sections to convey this clarification.
| // The pattern for a CopyMap with a fixed quantity of heterogeneous entry | ||
| // types is merely a CopyMap of corresponding key and value patterns, for | ||
| // example, | ||
| // makeCopyMap([[M.string(), M.number()], [M.number(), M.string()]]). |
There was a problem hiding this comment.
No. The keys must be keys. Only the values can be non-key patterns.
There was a problem hiding this comment.
Rewrote record and map to clarify this distinction.
kriskowal
changed the title
kriskowal
force-pushed
the
kriskowal-patterns-struct
branch
from
72e6090
to
1f51d83
Compare
kriskowal
changed the title
kriskowal
force-pushed
the
kriskowal-patterns-struct
branch
3 times, most recently
from
6ce1307
to
705a32c
Compare
Rewrote all sections to speak in terms of the copy data that each pattern matches instead of using TypeScript. Covered CopyRecord, CopyArray, and CopyMaps. Tags aren’t heterogeneous collections. CopySet and CopyBag are collections but can’t be fixed-length and heterogeneous with types for corresponding keys or indexes, so they’re out. |
kriskowal
force-pushed
the
kriskowal-patterns-struct
branch
from
705a32c
to
a39d236
Compare
Until we have a rigorous treatment on the usage of patterns, this adds a bandaid to the code itself so anyone looking for how to make a pattern for a struct-like CopyRecord, tuple-like CopyArray, or fixed-length heterogeneous CopyMap will find their way.