Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional dot-delimited petname path support #2296

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

FUDCo
Copy link
Collaborator

@FUDCo FUDCo commented May 22, 2024

Ref: #2023

Adds support for dot-delimited petname paths in the bundle, cat, follow, open, and run commands. Cleans up handling in the list command.

@FUDCo FUDCo requested review from kriskowal and rekmarks May 22, 2024 20:52
@FUDCo FUDCo self-assigned this May 22, 2024
Copy link
Contributor

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

packages/cli/src/commands/cat.js Outdated Show resolved Hide resolved
packages/cli/src/commands/bundle.js Show resolved Hide resolved
packages/cli/src/commands/follow.js Outdated Show resolved Hide resolved
packages/cli/src/commands/open.js Outdated Show resolved Hide resolved
packages/cli/src/commands/run.js Outdated Show resolved Hide resolved
@FUDCo FUDCo requested a review from rekmarks May 23, 2024 23:37
Copy link
Contributor

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Adds support for dot-delimited petname paths in the `bundle`, `cat`,
`follow`, `open`, and `run` commands.  Cleans up handling in the
`list` command.
@FUDCo FUDCo merged commit 0db5815 into master May 24, 2024
17 checks passed
@FUDCo FUDCo deleted the 2023-more-path-support branch May 24, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants