New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Best effort assert printing #772
Conversation
I can check whether this addresses the specific case that I reported, but ... the whole agoric-sdk seems to assume that anything can be stringified. For example, the |
Meanwhile, to reproduce the problem: build
|
@dckc this is now ready for review. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff.
I made one editorial suggestion for you to consider.
Fixes #729
@dckc I should still take your suggestion to give detailsTokens their own
toString
method. However, that solves less of the problem. For example, the test case added in this PR would still fail. Instead, where theassert
module itself stringifies something directly, not throughdetails
, it would now stringify thequote
of it. IOW, it would usebestEffortStringify
.Since I don't yet know how to reproduce #729, I'll start with this PR, and take your suggestion later after we see if this PR solves your problem.