Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add explicit imports for types #28

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: Add explicit imports for types #28

merged 1 commit into from
Nov 6, 2023

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Nov 6, 2023

Don't rely on Rust prelude, use explicit imports.

@Hywan
fix: Add explicit imports for types.
31aa817 
Don't rely on Rust prelude, use explicit imports.
waywardmonkeys
waywardmonkeys approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this, but would it make sense to add an external test case that picks up whatever was failing here to avoid it happening again? (In a subsequent PR)

@waywardmonkeys waywardmonkeys merged commit b0d03d9 into endoli:main Nov 6, 2023
5 checks passed
@Hywan
Copy link
Contributor Author

Hywan commented Nov 6, 2023

I can try yeah.

@Hywan Hywan mentioned this pull request Nov 6, 2023
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hywan @waywardmonkeys