Release JSPropertyNameArrayRef. Retain string. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `JSObjectCopyPropertyNames` returns the name array under the create rule, we need to release it when it is dropped. Since it owns the strings, and the strings can outlive the name array (like when iterating over the names and storing the string references), we need to retain them to keep them alive.
|
@Hywan Thoughts? |
|
@Hywan Checking in on this before I land it in a while… |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
JSObjectCopyPropertyNamesreturns the name array under the create rule, we need to release it when it is dropped.Since it owns the strings, and the strings can outlive the name array (like when iterating over the names and storing the string references), we need to retain them to keep them alive.