Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json api rc3 #12

Merged
merged 2 commits into from Apr 27, 2015
Merged

Json api rc3 #12

merged 2 commits into from Apr 27, 2015

Conversation

bmac
Copy link
Member

@bmac bmac commented Apr 22, 2015

This uses the work from this pr emberjs/data#2904 to implement JSON API rc3. Any bugs we find in the json-api-* files should be upstreamed to Ember Data.

cc @bobholt @tkellen @leobalter

@leobalter
Copy link
Contributor

seems very interesting. I'll try to manually get this code and test against my app. Meanwhile, is there anyway to set proper tests to it?

@bmac
Copy link
Member Author

bmac commented Apr 22, 2015

Yeah, thats on my list of things to do. Most of the json-api-* code is already tested in the Ember Data pr so I'd prefer not to duplicate that work. However, things like the underscoring keyForAttribute and keyForRelationship should be tested in this repo.

@leobalter
Copy link
Contributor

rad!

@bobholt
Copy link
Contributor

bobholt commented Apr 23, 2015

Excited that I may not have to do anything! I'll try to put this into Away today. I just have to remember how to ember.

bmac added a commit that referenced this pull request Apr 27, 2015
@bmac bmac merged commit bd59541 into master Apr 27, 2015
@bmac bmac deleted the json-api-rc3 branch April 27, 2015 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants