-
-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trouble running tests on PHP 8 with github actions using this lib #282
Comments
Ohhh - I think it's actually because |
See endroid/qr-code#282 and endroid/qr-code#283 Turns out PHP 8 changed `gd` to return objects rather than resources. This should work as a quick fix to not throw an exception in PHP 8.
Hi @francislavoie this should be fixed. |
Hey! In what version is this fixed? Because I'm using 3.9.6 (which seems to be the latest one), and I can still see this errors. Also, If I check the source code inside my vendor folder, it's still doing this Am I missing something? 🤔 |
Hi @acelaya this should be fixed in the 3.x branch and awaiting update of an external library before it completely supports PHP 8 and can be tagged. |
Perfect. Thanks for the info. |
@endroid Can we help for something to tag a new release? |
@ThibaudDauce unfortunately I think not :) I hope to have a 4.x release soon which allows usage of the library without requiring that package but for now if you need to run in PHP 8 you can use the temporary workaround mentioned in #292. |
See Vectorface/GoogleAuthenticator#2
You can see the test failures here: https://github.com/Vectorface/GoogleAuthenticator/pull/2/checks?check_run_id=1484500680
FYI the dependency of this lib that is causing failures in your builds is now fixed to support PHP 8: khanamiryan/php-qrcode-detector-decoder#98 with this release: https://github.com/khanamiryan/php-qrcode-detector-decoder/releases/tag/1.0.4
I'm not sure why GD would be failing on PHP 8. This lib doesn't emit any useful information as to why it might be the case. It definitely gets past the check for the extension being loaded, but then it fails on
imagecreatetruecolor()
qr-code/src/Writer/PngWriter.php
Lines 71 to 75 in ad1aa6c
The text was updated successfully, but these errors were encountered: