ED-83: Date created is not being displayed correctly on tbdrugorder.csv #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be minor, so I'm going to go ahead and merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for: https://tickets.pih-emr.org/browse/ED-83
When opening a CSV in Excel, if a datetime field contains a fraction of second component, Excel by default interprets the data as just a time, and displays only the time component. Users have to manually change the type of the column in Excel.
It appears that if we use DATE_FORMAT to format dates to not include the fraction of a second component, the issue is resolved.
@davidoh @SwathiVarkala let us know if you see any issues with this commit before we merge it in. I've tested it locally, but will furthermore test it on our staging server after we merge it in. Thanks!