fix(claim): fix claim service issuance interfaces

energywebfoundation · May 4, 2022 · 4c32a26 · 4c32a26
1 parent a648832
commit 4c32a26
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/docs/api/interfaces/modules_claims.IssueClaimRequestOptions.md b/docs/api/interfaces/modules_claims.IssueClaimRequestOptions.md
@@ -58,7 +58,7 @@ ___
 
 ### subjectAgreement
 
-• **subjectAgreement**: `string`
+• `Optional` **subjectAgreement**: `string`
 
 Subject agreement signature
 

diff --git a/src/errors/error-messages.ts b/src/errors/error-messages.ts
@@ -27,4 +27,5 @@ export enum ERROR_MESSAGES {
   IS_ETH_SIGNER_NOT_SET = 'Can not determine if signer is conformant with eth_sign specification',
   SIGN_TYPED_DATA_NOT_SUPPORTED = 'Sign typed data not supported',
   CLAIM_TYPE_MISSING = 'Claim type is required for On-chain registration',
+  ONCHAIN_ROLE_SUBJECT_AGREEMENT_NOT_SPECIFIED = 'On-chain role subject agreement not specified',
 }
diff --git a/src/modules/claims/claims.service.ts b/src/modules/claims/claims.service.ts
@@ -364,6 +364,11 @@ export class ClaimsService {
         expiry,
         sub
       );
+      if (!subjectAgreement) {
+        throw new Error(
+          ERROR_MESSAGES.ONCHAIN_ROLE_SUBJECT_AGREEMENT_NOT_SPECIFIED
+        );
+      }
       message.onChainProof = onChainProof;
       if (publishOnChain) {
         await this.registerOnchain({

diff --git a/src/modules/claims/claims.types.ts b/src/modules/claims/claims.types.ts
@@ -164,7 +164,7 @@ export interface IssueClaimRequestOptions {
   id: string;
 
   /** Subject agreement signature */
-  subjectAgreement: string;
+  subjectAgreement?: string;
 
   /** Registration types */
   registrationTypes: RegistrationTypes[];