Merge pull request #254 from energywebfoundation/transfer_assets_use_…

…address refactor(asset): drop support for DID format when offering asset. Use address instead BREAKING CHANGE: transferring asset do not allow anymore to use DID format. Allowed is address.
energywebfoundation · Sep 14, 2021 · 624e37c · 624e37c
2 parents ffe4357 + 8e2836f
commit 624e37c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/iam.ts b/src/iam.ts
@@ -1809,9 +1809,8 @@ export class IAM extends IAMBase {
         if (!this._address) {
             throw new Error(ERROR_MESSAGES.USER_NOT_LOGGED_IN);
         }
-        const [, , offerToAddress] = offerTo.split(":");
         const [, , assetContractAddress] = assetDID.split(":");
-        const tx = this.offerAssetTx({ assetContractAddress, offerTo: offerToAddress });
+        const tx = this.offerAssetTx({ assetContractAddress, offerTo });
         await this.send({
             calls: [tx],
             from: this._address,

diff --git a/test/assets.testsuite.ts b/test/assets.testsuite.ts
@@ -26,7 +26,7 @@ export const assetsTests = () => {
         const newOwner = new Keys();
         await rootOwnerIam.offerAsset({
             assetDID: `did:ethr:${assetAddress}`,
-            offerTo: `did:ethr:${newOwner.getAddress()}`,
+            offerTo: `${newOwner.getAddress()}`,
         });
         const assetContract = OfferableIdentity__factory.connect(assetAddress, provider);
         const offered = await assetContract.offeredTo();
@@ -38,7 +38,7 @@ export const assetsTests = () => {
         const assetDID = `did:ethr:${assetAddress}`;
         await rootOwnerIam.offerAsset({
             assetDID,
-            offerTo: `did:ethr:${newOwner.getAddress()}`,
+            offerTo: `${newOwner.getAddress()}`,
         });
         const assetContract = OfferableIdentity__factory.connect(assetAddress, provider);
         const offered = await assetContract.offeredTo();
@@ -52,7 +52,7 @@ export const assetsTests = () => {
         const newOwner = new Keys();
         await replenish(newOwner.getAddress());
         const assetDID = `did:ethr:${assetAddress}`;
-        await rootOwnerIam.offerAsset({ assetDID, offerTo: `did:ethr:${newOwner.getAddress()}` });
+        await rootOwnerIam.offerAsset({ assetDID, offerTo: `${newOwner.getAddress()}` });
         const newOwnerIAM = new IAM({
             privateKey: newOwner.privateKey,
             rpcUrl,
@@ -73,7 +73,7 @@ export const assetsTests = () => {
         const newOwner = new Keys();
         await replenish(newOwner.getAddress());
         const assetDID = `did:ethr:${assetAddress}`;
-        await rootOwnerIam.offerAsset({ assetDID, offerTo: `did:ethr:${newOwner.getAddress()}` });
+        await rootOwnerIam.offerAsset({ assetDID, offerTo: `${newOwner.getAddress()}` });
         const newOwnerIAM = new IAM({
             privateKey: newOwner.privateKey,
             rpcUrl,