fix(addVcVerifier): return type for Domain Reader

energywebfoundation · Jun 29, 2022 · 84ba78f · 84ba78f
1 parent 9eb00ac
commit 84ba78f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 13 deletions.
diff --git a/docs/api/classes/modules_domains.DomainsService.md b/docs/api/classes/modules_domains.DomainsService.md
@@ -17,6 +17,10 @@ domainsService.createOrganization(...);
 
 - [constructor](modules_domains.DomainsService.md#constructor)
 
+### Accessors
+
+- [domainReader](modules_domains.DomainsService.md#domainreader)
+
 ### Methods
 
 - [changeAppOwnership](modules_domains.DomainsService.md#changeappownership)
@@ -34,7 +38,6 @@ domainsService.createOrganization(...);
 - [getAppsOfOrg](modules_domains.DomainsService.md#getappsoforg)
 - [getDIDsByRole](modules_domains.DomainsService.md#getdidsbyrole)
 - [getDefinition](modules_domains.DomainsService.md#getdefinition)
-- [getDomainReader](modules_domains.DomainsService.md#getdomainreader)
 - [getENSTypesByOwner](modules_domains.DomainsService.md#getenstypesbyowner)
 - [getENSTypesBySearchPhrase](modules_domains.DomainsService.md#getenstypesbysearchphrase)
 - [getOrgHierarchy](modules_domains.DomainsService.md#getorghierarchy)
@@ -64,6 +67,16 @@ domainsService.createOrganization(...);
 | `_signerService` | [`SignerService`](modules_signer.SignerService.md) |
 | `_cacheClient` | [`CacheClient`](modules_cache_client.CacheClient.md) |
 
+## Accessors
+
+### domainReader
+
+• `get` **domainReader**(): `DomainReader`
+
+#### Returns
+
+`DomainReader`
+
 ## Methods
 
 ### changeAppOwnership
@@ -479,16 +492,6 @@ domain definition
 
 ___
 
-### getDomainReader
-
-▸ **getDomainReader**(): `DomainReader`
-
-#### Returns
-
-`DomainReader`
-
-___
-
 ### getENSTypesByOwner
 
 ▸ **getENSTypesByOwner**(`options`): `Promise`<[`IRole`](../interfaces/modules_domains.IRole.md)[] \| [`IOrganization`](../interfaces/modules_domains.IOrganization.md)[] \| [`IApp`](../interfaces/modules_domains.IApp.md)[]\>

diff --git a/src/modules/claims/claims.service.ts b/src/modules/claims/claims.service.ts
@@ -1365,7 +1365,7 @@ export class ClaimsService {
       this._didRegistry.registrySettings,
       this._didRegistry.ipfsStore
     );
-    const domainReader = this._domainsService.getDomainReader();
+    const domainReader = this._domainsService.domainReader;
     const issuerResolver = new EthersProviderIssuerResolver(domainReader);
     this._vcIssuerVerifier = new VCIssuerVerification(
       credentialResolver,

diff --git a/src/modules/domains/domains.service.ts b/src/modules/domains/domains.service.ts
@@ -1413,7 +1413,7 @@ export class DomainsService {
     }
   }
 
-  getDomainReader() {
+  get domainReader(): DomainReader {
    return this._domainDefinitionReader;
   }
 }