refactor!: drop support for DID format when offering asset. Use address instead #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGiter
reviewed
Sep 14, 2021
| const [, , assetContractAddress] = assetDID.split(":"); | ||
| const tx = this.offerAssetTx({ assetContractAddress, offerTo: offerToAddress }); | ||
| const tx = this.offerAssetTx({ assetContractAddress, offerTo }); |
There was a problem hiding this comment.
Is this because it forces you to prepend address with did:ethr?
There was a problem hiding this comment.
what i read the ! in commit message is for Breaking change. Here I read that: https://www.conventionalcommits.org/en/v1.0.0/ Maybe it is not the same solution for commit messages? 🤔 I can remove it if you want.
Yes, we can just use address instead of DID format here like in transferring organizations. It unifies solutions.
There was a problem hiding this comment.
We are using semantic-release, which requires angular commit message format https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#-commit-message-guidelines. It doesn't mention such option
There was a problem hiding this comment.
Ok, i will remove it then. I will add a footer with information about breaking change.
… address instead BREAKING CHANGE: transferring asset do not allow anymore to use DID format. Allowed is address.
dawidgil
force-pushed
the
transfer_assets_use_address
branch
from
2394bc0
to
8e2836f
Compare
JGiter
approved these changes
Sep 14, 2021
JGiter
pushed a commit
that referenced
this pull request
Sep 21, 2021
# [3.0.0](v2.2.0...v3.0.0) (2021-09-21) ### Bug Fixes * add subject in claim request ([7859337](7859337)) * adds build:api_docs to deployment process ([f191600](f191600)) * adds build:api_docs to deployment process ([6343e86](6343e86)) * adds method to parse did ([8107ce8](8107ce8)) * auth semantic-release to gh ([4fa4c95](4fa4c95)) * catch env detect error ([8c8edca](8c8edca)) * check pub key from cache ([4f6180f](4f6180f)) * check sub is DID ([4c8513f](4c8513f)) * correct description ([3fc3653](3fc3653)) * create proxy operator for identity addr ([3e799a4](3e799a4)) * default claim subject to requester ([390d8fa](390d8fa)) * dont commit unstage ([eaf521b](eaf521b)) * double node migration ([101e4d2](101e4d2)) * exporting interfaces for claim data. ([ac9d5d2](ac9d5d2)) * init did signer from Metamask ([d783d44](d783d44)) * login as different account issus ([5f75176](5f75176)) * maintain login on reload ([9018f07](9018f07)) * make did to be address agnostic ([1831949](1831949)) * merge published master in dev ([5c7493d](5c7493d)) * no sense setting DID if address hasn't been set ([8b182df](8b182df)) * not create asset document ([9b91177](9b91177)) * persist gh token in action ([8ed156f](8ed156f)) * rename get claim flags ([435e360](435e360)) * rename getIssuedClaims ([6dde43b](6dde43b)) * rename getRequestedClaims ([3657128](3657128)) * rename namespace query param ([11d7001](11d7001)) * replace GITHUB_TOKEN with PAT ([3c81daf](3c81daf)) * rm double develop fetch ([d2b5ac8](d2b5ac8)) * rm double develop fetch ([b1ef6b1](b1ef6b1)) * scripts for building and testing in windows operating system ([50d02d5](50d02d5)) * setting session in local storage after successful login. ([206bcaa](206bcaa)) * throwing an error when initializing wallet provider. ([bea90e3](bea90e3)) * use precise version of ew-did-registry packages ([4361bf5](4361bf5)) * **cacheServerClient:** log in if refresh token is expired ([557a767](557a767)) * **chainConfig:** fixed public RPC url for Volta ([8faf28f](8faf28f)) * **change_resolver:** remove import from ethers subpaths ([8397652](8397652)) * **claims:** revert rm Claim.subject ([8cebeee](8cebeee)) * **createClaimRequest:** use subjectAgreement ([427f4a8](427f4a8)) * **deleteClaim:** throw CacheClientNotProvided if necessary ([3af43ee](3af43ee)) * **iam:** parse claimData from requested token ([8de9935](8de9935)) * **iam.issueClaim:** move claimTypeVersion into claimData ([3a72523](3a72523)) * **iam.issueClaimRequest:** remove claimTypeVersion from jwt.decode ([5665ba1](5665ba1)) * **init:** prioritize loginToCacheServer key if available ([905fa75](905fa75)) * **staking:** blockchain now ([768dc5d](768dc5d)) * **staking:** delay getters to return number ([253888f](253888f)) * **staking:** hardcode tx overrides ([5ed6eda](5ed6eda)) * **staking:** update iam-contracts ([bcd3bc9](bcd3bc9)) * update asset manager ([2edbe6e](2edbe6e)) * updates documentation to state DID document perequisite ([4057da9](4057da9)) * verify prerequisites registered onchain ([3491357](3491357)) * **staking:** withdrawalDelay ([f97fedf](f97fedf)) ### Performance Improvements * decrease staking delay ([4eb64ad](4eb64ad)) * mock ipfs in tests ([f710747](f710747)) * remove listeners in tests ([3122275](3122275)) * Merge pull request #254 from energywebfoundation/transfer_assets_use_address ([624e37c](624e37c)), closes [#254](#254) * refactor!: rename verifyPublicToken param name ([1d65b89](1d65b89)) ### chore * unsubscribe from given subscription ([6984c11](6984c11)) ### Code Refactoring * **asset:** drop support for DID format when offering asset. Use address instead ([8e2836f](8e2836f)) * rename initDID to createDocument ([585a4ee](585a4ee)) * rename initDID to createDocument ([bc86ec1](bc86ec1)) * rename initDID to createDocument ([9a895ab](9a895ab)) * rename initDID to createDocument ([b08a68a](b08a68a)) ### Features * init signer by provider type ([00b4e56](00b4e56)) * separate conn to cache and DID reg ([06b990b](06b990b)) * stake whole balance ([07ad380](07ad380)) * update did-reg package to fix EDR-36 ([f5dd772](f5dd772)) * update ew-did-registry ([639ff91](639ff91)) * **iam:** migrate legacy definitions during edit ([9656515](9656515)) * **staking:** check balance is sufficient ([0f049ee](0f049ee)) * **staking:** expose staking API ([6d6936f](6d6936f)) * **staking:** speed up tx ([572d9dd](572d9dd)) * add @energyweb/iam-contracts ([00376e8](00376e8)) * add RegistrationTypes export ([1881b60](1881b60)) * enroll with registration types ([d8f12d7](d8f12d7)) * get claims by subjects ([0728bc4](0728bc4)) * get role registration types ([ffd22ec](ffd22ec)) * issue on-chain role ([db0d42a](db0d42a)) * issued claim includes only role info ([0d403a0](0d403a0)) * no need to provide issues to request role ([95dab41](95dab41)) * publish owned identity claim ([da8e375](da8e375)) * read and write of new roledefinition smart contract ([dc632c8](dc632c8)) * request asset enrollment ([c65e883](c65e883)) * update iam-contracts to 1.15.2 ([c7dff19](c7dff19)) * update identity manager address ([75bd012](75bd012)) * using IPublicClaim to issue credential ([12dcedf](12dcedf)) * **assets:** add asset smart contract integration ([68b68db](68b68db)) ### BREAKING CHANGES * transferring asset do not allow anymore to use DID format. Allowed is address. * **asset:** transferring asset do not allow anymore to use DID format. Allowed is address. * Rename the prop name from `issuedToken` to `claimUrl` in method `verifyPublicClaim` in `IAM` class. * change initialization API * change initialization API * change initialization API * change initialization API * signature of unsubscribe and subscribe changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While offering asset to other user let's use address instead of did format.