Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ew-credentials 2.0.1-alpha.275.0 #646

Merged
merged 2 commits into from
Sep 2, 2022
Merged

update ew-credentials 2.0.1-alpha.275.0 #646

merged 2 commits into from
Sep 2, 2022

Conversation

JGiter
Copy link
Collaborator

@JGiter JGiter commented Sep 1, 2022 •
edited

Description

Contributor checklist

  • Breaking changes - check for any existing interfaces changes that are not backward compatible, removed method etc.
  • Documentation - document your code, add comments for method, remember to check if auto generated docs were updated.
  • Tests - add new or updated existed test for changes you made.
  • Migration guide - add migration guide for every breaking change.
  • Configuration correctness - check that any configuration changes are correct ex. default URLs, chain ids, smart contract verification on Volta explorer or EWC explorer.

@JGiter JGiter force-pushed the update_ew-credentials branch 2 times, most recently from 989392c to addebbf Compare September 2, 2022 05:01
@nichonien
Copy link
Contributor

nichonien commented Sep 2, 2022 •
edited

@JGiter We can use the latest version of ew-did-registry which is 0.7.1-alpha.808.0 . This has my changes, thanks!

@JGiter
Copy link
Collaborator Author

JGiter commented Sep 2, 2022

@JGiter We can use the latest version of ew-did-registry which is 0.7.1-alpha.808.0 . This has my changes, thanks!

Is this require another round of updating of ew-credentials?

@nichonien
Copy link
Contributor

Is this require another round of updating of ew-credentials?

No, only the ew-did-registry has the changes.

@nichonien
Copy link
Contributor

@JGiter My bad, there is a signature change for method and this is resulting is workflow fail. Maybe you can go back to the older version and I would update to latest making these changes in iam-cleint-lib.

@JGiter
Copy link
Collaborator Author

JGiter commented Sep 2, 2022

@JGiter My bad, there is a signature change for method and this is resulting is workflow fail. Maybe you can go back to the older version and I would update to latest making these changes in iam-cleint-lib.

Ok, I'll revert

@JGiter JGiter force-pushed the update_ew-credentials branch 2 times, most recently from 798e294 to f765faa Compare September 2, 2022 06:30
@JGiter JGiter merged commit 7a91e28 into develop Sep 2, 2022
@ewf-devops
Copy link

🎉 This PR is included in version 6.1.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ewf-devops
Copy link

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jrhender jrhender deleted the update_ew-credentials branch December 6, 2022 10:17
@snyk-bot snyk-bot mentioned this pull request Jan 11, 2023
Closed
@michalziobro michalziobro mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichonien nichonien nichonien approved these changes

Assignees
No one assigned
Labels
released on @canary released on @latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JGiter @nichonien @ewf-devops