Feat/swtch 2493/no master build #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhender
commented
Sep 19, 2023
devops/staging/values.yaml
Outdated
| @@ -7,6 +7,7 @@ iam-cache-server-helm: | |||
|
|
|||
| image: | |||
| repository: "ghcr.io/energywebfoundation/ssi-hub" | |||
| tag: dce9b11b-2242-4b17-8087-e8bfbcb98d98 | |||
There was a problem hiding this comment.
I want to merge develop to release to get a new stable release tomorrow and then use this release instead of this tag
There was a problem hiding this comment.
based on what you said, i think you don't need to over-write this tag
There was a problem hiding this comment.
What do you mean @vickenliu ? I think I do need to specify which image version we want to run in the staging env. But maybe I'm missing my own point 😆
JGiter
approved these changes
Sep 20, 2023
JGiter
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
masterbranch)master. We can put this back later if staging env is disconnected frommasterbranch in the future@Timtech4u adding you as reviewer as you helped setup the ssi-hub build for gp4btc so you might remember something about this area