Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add code of conduct #174

Merged
merged 2 commits into from
Jul 17, 2023
Merged

docs: add code of conduct #174

merged 2 commits into from
Jul 17, 2023

Conversation

nichonien
Copy link
Contributor

No description provided.

@nichonien nichonien requested a review from jrhender July 12, 2023 09:28
Copy link
Collaborator

@jrhender jrhender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nichonien what's the rationale for having the code of conduct at the root and under apps/vc-api? In my opinion, just having it at the root would be sufficient. As a comparison, we only have one LICENSE file, which is at the root (as far as I can tell).

@nichonien
Copy link
Contributor Author

@nichonien what's the rationale for having the code of conduct at the root and under apps/vc-api? In my opinion, just having it at the root would be sufficient. As a comparison, we only have one LICENSE file, which is at the root (as far as I can tell).

Yeah, I added it because we are proposing vc-api to OWF and if someone looks at the repo they should be able to find the code-of-conduct rather than going to the root. Also if we need to move the vc-api to separate repo then we won't need to add it again. We can do the same for LICENSE too. What do you think?

Copy link
Collaborator

@jrhender jrhender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@nichonien nichonien merged commit c9755be into develop Jul 17, 2023
2 checks passed
@jrhender jrhender deleted the add-code-of-conduct branch September 20, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants