Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-descriptor-to-credential): fixing Swagger UI crashing #181

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

artursudnik
Copy link
Member

No description provided.

@artursudnik artursudnik self-assigned this Sep 25, 2023

export class InputDescriptorToCredentialResponseDto {
@Type(() => CredentialDto)
@ValidateNested()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not want @ValidateNested anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is response DTO, so the class-validator is not executed on this.

Copy link
Collaborator

@jrhender jrhender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @artursudnik

@artursudnik artursudnik merged commit cdd82db into develop Sep 26, 2023
2 checks passed
@artursudnik artursudnik deleted the fix/fixing-swagger-ui-crashing branch September 26, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants