Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support expo-modules #57

Merged
merged 1 commit into from Jan 18, 2022
Merged

Conversation

sonnysantino
Copy link
Contributor

As pointed on #53 since expo sdk 43 the react-native-unimodules is deprecated in favor of expo-modules, but this package installs the version 9.x of expo-blur & expo-haptics that uses unimodules.

This can be fixed by moving the dependecies to peers so it will rely on the ones that the main project has installed, avoiding any conflict and making it compatible with any expo sdk version.

Solves #53

@bfischer1121
Copy link

+1

@Noitidart
Copy link

This is awesome it works! Thanks for it! For those on Expo that want to use this before it gets merged to master you can install it like this:

npm i sonnysantino/react-native-hold-menu#fix/expo-modules

Of course remember to install the peer deps:

expo install expo-haptics expo-blur

@giautm
Copy link

giautm commented Jan 13, 2022

This is awesome it works! Thanks for it! For those on Expo that want to use this before it gets merged to master you can install it like this:


npm i sonnysantino/react-native-hold-menu#fix/expo-modules

Of course remember to install the peer deps:


expo install expo-haptics expo-blur

Npm resolutions is the easy way. Just lock expo-haptics expo-blur to the correct version.

@hirbod
Copy link

hirbod commented Jan 16, 2022

Not npm resolutions, but yarn. There are packages that aim to bring support for npm though.
Pinning expo-haptics and expo-blur should be enough to get rid of unimodules.

@enesozturk is there any chance you could just fix the peerDependencies and release a new version to get rid of this?

@enesozturk
Copy link
Owner

Hi @sonnysantino, this is very helpful! Thanks, I will merge and release a new version soon.

@enesozturk enesozturk merged commit 5897e78 into enesozturk:main Jan 18, 2022
@enesozturk
Copy link
Owner

@sonnysantino one thing I am not sure, in the getting started page you added expo-blur and expo-haptic but react-native-unimodules still exist, should it be still installed?

@giautm
Copy link

giautm commented Jan 18, 2022

@enesozturk No, don't need to install react-native-unimodules on the new SDK.

@hirbod
Copy link

hirbod commented Jan 18, 2022

I would make a major version bump and release the old version under a Tag to support < SDK 44

@enesozturk
Copy link
Owner

enesozturk commented Jan 18, 2022

That is great, thanks for the information guys.
@hirbod, I am not sure how to do it in best practice that versioning & tagging, would appreciate your help 🙌🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants