Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bestie: Raise max gRPC message size #760

Merged
merged 1 commit into from Sep 16, 2022
Merged

bestie: Raise max gRPC message size #760

merged 1 commit into from Sep 16, 2022

Conversation

minor-fixes
Copy link
Contributor

Bestie is rejecting messages larger than the gRPC server default of 4MB. Since bazel targets message sizes of up to 50MB, bestie should support this as well.

This change adds a server option that sets the maximum allowed message size to a flag value, which has a default of 50MB.

Tested: no

Jira: INFRA-1828

gpaussaenf
gpaussaenf approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@gpaussaenf gpaussaenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think the existing 5 MB output file size limit is sufficient for now.

msgoldflam
msgoldflam approved these changes Sep 15, 2022
View reviewed changes
Copy link

@msgoldflam msgoldflam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but when I looked it up I also saw MaxRecvMsgSize and MaxSendMsgSize. Make sure these don't need to be changed also

@minor-fixes
Copy link
Contributor Author

Approving, but when I looked it up I also saw MaxRecvMsgSize and MaxSendMsgSize. Make sure these don't need to be changed also

Yeah, on inspection of the Go docs (https://pkg.go.dev/google.golang.org/grpc#MaxMsgSize) it looks like:

  • MaxMsgSize is deprecated
  • MaxRecvMsg size has the low default of 4MB
  • MaxSendMsgSize has a default of maxint (setting it will actually lower the value)

...so I'll change to just setting the receive size instead.

@minor-fixes
bestie: Raise max gRPC message size
9061745 
Bestie is rejecting messages larger than the gRPC server default of 4MB.
Since bazel targets message sizes of up to 50MB, bestie should support
this as well.

This change adds a server option that sets the maximum allowed message
size to a flag value, which has a default of 50MB.

Tested: no

Jira: INFRA-1828
@minor-fixes minor-fixes merged commit 7178f56 into enfabrica:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccontavalli ccontavalli ccontavalli approved these changes

@mhallmark mhallmark mhallmark approved these changes

@msgoldflam msgoldflam msgoldflam approved these changes

@gpaussaenf gpaussaenf gpaussaenf approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@minor-fixes @ccontavalli @mhallmark @msgoldflam @gpaussaenf