Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced depricated no-gutters with g-0 #608

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

bryanmontalvan
Copy link
Member

Description

This PR will fix the issue where we have horizontal overflow (meaning you could scroll horizontally) along with the issue of having a thick vertical line between the editor and the 3D space.

The issue was when we upgraded the version of bootstrap (4.6 -> 5.1). It seems the no-gutters bootstrap class has been deprecated and now instead is g-0.

Preview

Before:
image
After:
image

This commit fixes the issue where we had horizontal overflow along with a thick vertical line between the IDE and 3D space.

Signed-off-by: Bryan Mointalvan <bryan_montalvanarevalo@student.uml.edu>
@bryanmontalvan bryanmontalvan requested review from a team, jdones01, jf-kelly and davidjonesma and removed request for a team July 19, 2022 15:23
@bryanmontalvan bryanmontalvan added the bug Something isn't working label Jul 19, 2022
Copy link
Contributor

@jf-kelly jf-kelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bryanmontalvan bryanmontalvan merged commit cac893b into engaging-computing:dev Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

None yet

2 participants