Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.2.1 #678

Merged
merged 33 commits into from
Jun 12, 2023
Merged

Version 3.2.1 #678

merged 33 commits into from
Jun 12, 2023

Conversation

rjmara
Copy link
Contributor

@rjmara rjmara commented Jun 12, 2023

Merging dev changes to master with the following changes:

  • Updating documentation for reference examples
  • Moved reset button to top of the editor
  • Bug fix for footer styling; updated code to have latest bootstrap changes
  • Bug fix for to vertical movement
  • Bug fix for display cursor setting
  • Bug fix for VR not working on mobile by downgrading A-Frame

rjmara and others added 30 commits August 9, 2022 13:54
Added form to submit user example scenes
Updated `shrink()` and `grow()` documentation to reference magnitude function
Fixed the function call for displayCursor
This commit downgrades aframe from 1.3 to 1.2, in turn fixing the VR not working on mobile
Downgraded A-Frame version to fix VR bug
When we updated bootstrap, the elements in the footer became misaligned. To fix this, I used the classes from the current 5.1 version of bootstrap. Additionally, when selecting courses, the current version of MYR makes the header and paragraph of each course underlined. I just changed the style for this so that each part of the card does not have an underline upon opening the course menu. Then, when someone hovers over the course, only the header becomes underlined.
Updating styles for the footer and course select
@rjmara rjmara requested a review from jf-kelly June 12, 2023 17:16
Copy link
Contributor

@jf-kelly jf-kelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rjmara rjmara merged commit d13e29a into master Jun 12, 2023
3 checks passed
@CBernsCode
Copy link
Contributor

CBernsCode commented Jun 13, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants