-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3.2.1 #678
Merged
Version 3.2.1 #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of setMagnitude()
Added form to submit user example scenes
Reset button
Updated `shrink()` and `grow()` documentation to reference magnitude function
Fixed Vertical Movement
Revert "Fixed Vertical Movement"
Vertical movement fix - third try
Update ReferenceExample.js
Fixed the function call for displayCursor
This commit downgrades aframe from 1.3 to 1.2, in turn fixing the VR not working on mobile
Downgraded A-Frame version to fix VR bug
Revert 671 vr fix
When we updated bootstrap, the elements in the footer became misaligned. To fix this, I used the classes from the current 5.1 version of bootstrap. Additionally, when selecting courses, the current version of MYR makes the header and paragraph of each course underlined. I just changed the style for this so that each part of the card does not have an underline upon opening the course menu. Then, when someone hovers over the course, only the header becomes underlined.
Updating styles for the footer and course select
Downded AFrame to 1.2
Downgrade AFrame 1.3 -> 1.2
Package fix
jf-kelly
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Y’all should rebase to keep commit history clean
On Mon, Jun 12, 2023 at 10:34 AM ryan maradiaga ***@***.***> wrote:
Merged #678 <#678> into
master.
—
Reply to this email directly, view it on GitHub
<#678 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB76APWN6TY35UXGRV6HVG3XK5HLVANCNFSM6AAAAAAZDV2EME>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Sent from mobile, please excuse any typographical errors.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging dev changes to master with the following changes: