Skip to content

Commit

Permalink
Changing default Python 3.7 to 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel Engvall committed Dec 15, 2019
1 parent 5602bc7 commit 5b1b1a5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 15 deletions.
23 changes: 10 additions & 13 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
[![Build Status](https://travis-ci.com/engdan77/tasks_collector.svg?branch=master)](https://travis-ci.com/engdan77/tasks_collector)
[![Documentation Status](https://readthedocs.org/projects/tasks-collector/badge/?version=latest)](https://tasks-collector.readthedocs.io/en/latest/?badge=latest)
[![codecov](https://codecov.io/gh/engdan77/tasks_collector/branch/master/graph/badge.svg)](https://codecov.io/gh//engdan77/tasks_collector)
[![Python 3.7](https://img.shields.io/badge/python-3.7-blue.svg)](https://www.python.org/downloads/release/python-370/)
[![Python 3.8](https://img.shields.io/badge/python-3.8-blue.svg)](https://www.python.org/downloads/release/python-370/)

## Read The Docs
You can find the documentation including generated API docs at https://tasks-collector.readthedocs.io/en/latest/
Expand Down Expand Up @@ -153,9 +153,9 @@ Thanks to tox this has been automated so all that you need to run "tox" from pro
````bash
$ tox
...
py3.7.0 run-test: commands[0] | pytest --cov=tasks_collector tests/
py3.8.0 run-test: commands[0] | pytest --cov=tasks_collector tests/
........................... [100%]
---------- coverage: platform darwin, python 3.7.1-final-0 -----------
---------- coverage: platform darwin, python 3.8.0-final-0 -----------
Name Stmts Miss Cover
--------------------------------------------------------------------
tasks_collector/__init__.py 1 0 100%
Expand All @@ -167,17 +167,14 @@ tasks_collector/tasksdb/__init__.py 0 0 100%
tasks_collector/tasksdb/api.py 80 8 90%
tasks_collector/tasksscraper/__init__.py 0 0 100%
tasks_collector/tasksscraper/jirascraper.py 17 3 82%
tasks_collector/tasksscraper/outlookscraper.py 17 1 94%
tasks_collector/tasksscraper/outlookscraper.py 43 1 98%
tasks_collector/tasksscraper/trelloscraper.py 37 13 65%
--------------------------------------------------------------------
TOTAL 486 148 70%

27 passed, 4 warnings in 19.63s
__________________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________________
py3.4.0: commands succeeded
py3.5.6: commands succeeded
py3.6.6: commands succeeded
py3.7.0: commands succeeded
TOTAL 512 148 71%

29 passed, 4 warnings in 17.32s
______________________________________________________________________________________________________________________________________________________________________________ summary ______________________________________________________________________________________________________________________________________________________________________________
py3.8.0: commands succeeded
congratulations :)
````

Expand All @@ -197,7 +194,7 @@ Reasons for this happening on MacOS is that your built of Python3 does not inclu

One way around this if you'd be using pyenv (one of my favourites) found at https://github.com/pyenv/pyenv is to install Python using the following
```bash
env PYTHON_CONFIGURE_OPTS="--enable-framework CC=clang" pyenv install 3.7.0
env PYTHON_CONFIGURE_OPTS="--enable-framework=$(pyenv root)/versions/3.8.0 CC=clang --enable-unicode --with-threads" pyenv install 3.8.0 -v
```

## Contact
Expand Down
3 changes: 1 addition & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ python_files = test_*.py
norecursedirs = .tox

[tox]
envlist = py3.4.0,py3.5.6,py3.6.6,py3.7.0
# envlist = py3.7.0
envlist = py3.8.0

[coverage:run]
omit = tasks_collector/__main__.py
Expand Down

0 comments on commit 5b1b1a5

Please sign in to comment.