Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste content of mails into log when in dev mode #661

Open
msquare opened this issue Oct 13, 2019 · 1 comment
Open

Paste content of mails into log when in dev mode #661

msquare opened this issue Oct 13, 2019 · 1 comment
Labels
Status: Needs discussion Additional discussion/feedback is needed Type: Feature An idea for a new feature

Comments

@msquare
Copy link
Member

msquare commented Oct 13, 2019

Since mail is sometimes hard to setup in a local dev environment, maybe the content of a mail should be logged when engelsystem is in development mode?

@msquare msquare added Type: Feature An idea for a new feature Status: Needs discussion Additional discussion/feedback is needed labels Oct 13, 2019
@MyIgel
Copy link
Member

MyIgel commented Oct 13, 2019

The idea is imho good but means that we have inconsistent configs (php arrays can't reference themselves on creation) or some magic after the config file that changes stuff what is not the best way?

If we really want it we should set email.driver=null in the config.default.php and then do the magic according to the environment config in MailerServiceProvider::register.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs discussion Additional discussion/feedback is needed Type: Feature An idea for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants