Skip to content

Commit

Permalink
[flutter_runner] Enable Skia tracing by default on Fuchsia (flutter#1…
Browse files Browse the repository at this point in the history
…3457)

Since Flutter tracing is wired up to Fuchsia system level tracing (and
that includes Skia tracing within Flutter), it makes more sense to
enable Skia tracing by default on Fuchsia, and to control Flutter Skia
tracing, rely on whether Fuchsia system tracing is enabled, in progress,
and contains the "skia" category.
  • Loading branch information
nathanrogersgoogle committed Dec 12, 2019
1 parent 897ce34 commit 1ce85be
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions shell/platform/fuchsia/flutter/component.cc
Expand Up @@ -316,9 +316,8 @@ Application::Application(
settings_.observatory_host = "127.0.0.1";
#endif

// Set this to true to enable category "skia" trace events.
// TODO(PT-145): Explore enabling this by default.
settings_.trace_skia = false;
// Controls whether category "skia" trace events are enabled.
settings_.trace_skia = true;

settings_.icu_data_path = "";

Expand Down

0 comments on commit 1ce85be

Please sign in to comment.