test CkPath.reset() (flutter#21567)

engine-flutter-autoroll · Oct 5, 2020 · 3351524 · 3351524
1 parent 948dd97
commit 3351524
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/lib/web_ui/lib/src/engine/canvaskit/path.dart b/lib/web_ui/lib/src/engine/canvaskit/path.dart
@@ -257,6 +257,8 @@ class CkPath implements ui.Path {
 
   @override
   void reset() {
+    // Only reset the local field. Skia will reset its internal state via
+    // SkPath.reset() below.
     _fillType = ui.PathFillType.nonZero;
     _skPath.reset();
   }

diff --git a/..._ui/test/canvaskit/path_metrics_test.dart → lib/web_ui/test/canvaskit/path_test.dart b/..._ui/test/canvaskit/path_metrics_test.dart → lib/web_ui/test/canvaskit/path_test.dart
@@ -16,7 +16,7 @@ void main() {
 }
 
 void testMain() {
-  group('Path Metrics', () {
+  group('CkPath', () {
     setUpAll(() async {
       await ui.webOnlyInitializePlatform();
     });
@@ -72,5 +72,20 @@ void testMain() {
       expect(() => iter1.current, throwsRangeError);
       expect(() => iter2.current, throwsRangeError);
     });
+
+    test('CkPath.reset', () {
+      final ui.Path path = ui.Path();
+      expect(path, isA<CkPath>());
+      path.addRect(const ui.Rect.fromLTRB(0, 0, 10, 10));
+      expect(path.contains(const ui.Offset(5, 5)), isTrue);
+
+      expect(path.fillType, ui.PathFillType.nonZero);
+      path.fillType = ui.PathFillType.evenOdd;
+      expect(path.fillType, ui.PathFillType.evenOdd);
+
+      path.reset();
+      expect(path.fillType, ui.PathFillType.nonZero);
+      expect(path.contains(const ui.Offset(5, 5)), isFalse);
+    });
   }, skip: isIosSafari); // TODO: https://github.com/flutter/flutter/issues/60040
 }