[web] Skipping failing edge tests (flutter#16626)

* making edge default test browser on windows. adding some skips (not all) for methods failing on edge * skip failing tests. make egde default for testing * skip one more test * addressing reviewer comments. removing extra bat file
engine-flutter-autoroll · Feb 18, 2020 · 77c5812 · 77c5812
1 parent 46d341c
commit 77c5812
Show file tree

Hide file tree

Showing 11 changed files with 229 additions and 92 deletions.
diff --git a/lib/web_ui/dev/felt_windows.bat b/lib/web_ui/dev/felt_windows.bat
@@ -57,7 +57,7 @@ IF %orTempValue%==0 (
 :: TODO(nurhan): The batch script does not support snanphot option.
 :: Support snapshot option.
 CALL :installdeps
-%DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %*
+IF %1==test (%DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %* --browser=edge) ELSE ( %DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %* )
 
 EXIT /B 0
 

diff --git a/lib/web_ui/test/dom_renderer_test.dart b/lib/web_ui/test/dom_renderer_test.dart
@@ -99,7 +99,8 @@ void main() {
     expect(parent.innerHtml, '<a></a><b></b><c></c><d></d>');
   });
 
-  test('inneheight/innerWidth are equal to visualViewport height and width', () {
+  test('innerHeight/innerWidth are equal to visualViewport height and width',
+      () {
     if (html.window.visualViewport != null) {
       expect(html.window.visualViewport.width, html.window.innerWidth);
       expect(html.window.visualViewport.height, html.window.innerHeight);
@@ -115,13 +116,16 @@ void main() {
 
     final DomRenderer renderer = DomRenderer();
     renderer.reset();
-  }, // TODO(nurhan): https://github.com/flutter/flutter/issues/46638
-      skip: (browserEngine == BrowserEngine.firefox));
+  },
+      // TODO(nurhan): https://github.com/flutter/flutter/issues/46638
+      // TODO(nurhan): https://github.com/flutter/flutter/issues/50828
+      skip: (browserEngine == BrowserEngine.firefox ||
+          browserEngine == BrowserEngine.edge));
 
   test('accesibility placeholder is attached after creation', () {
     DomRenderer();
 
     expect(html.document.getElementsByTagName('flt-semantics-placeholder'),
-          isNotEmpty);
+        isNotEmpty);
   });
 }
diff --git a/lib/web_ui/test/engine/history_test.dart b/lib/web_ui/test/engine/history_test.dart
@@ -56,7 +56,9 @@ void main() {
 
       // The flutter entry is the current entry.
       expect(strategy.currentEntry, flutterEntry);
-    });
+    },
+        // TODO(nurhan): https://github.com/flutter/flutter/issues/50836
+        skip: browserEngine == BrowserEngine.edge);
 
     test('browser back button pops routes correctly', () async {
       strategy =
@@ -90,7 +92,9 @@ void main() {
       // The url of the current entry (flutter entry) should go back to /home.
       expect(strategy.currentEntry.state, flutterState);
       expect(strategy.currentEntry.url, '/home');
-    });
+    },
+        // TODO(nurhan): https://github.com/flutter/flutter/issues/50836
+        skip: browserEngine == BrowserEngine.edge);
 
     test('multiple browser back clicks', () async {
       strategy =
@@ -151,7 +155,9 @@ void main() {
       // 3. The active entry doesn't belong to our history anymore because we
       // navigated past it.
       expect(strategy.currentEntryIndex, -1);
-    });
+    },
+        // TODO(nurhan): https://github.com/flutter/flutter/issues/50836
+        skip: browserEngine == BrowserEngine.edge);
 
     test('handle user-provided url', () async {
       strategy =
@@ -190,7 +196,9 @@ void main() {
       expect(strategy.currentEntryIndex, 1);
       expect(strategy.currentEntry.state, flutterState);
       expect(strategy.currentEntry.url, '/home');
-    });
+    },
+        // TODO(nurhan): https://github.com/flutter/flutter/issues/50836
+        skip: browserEngine == BrowserEngine.edge);
 
     test('user types unknown url', () async {
       strategy =
@@ -212,7 +220,9 @@ void main() {
       expect(strategy.currentEntryIndex, 1);
       expect(strategy.currentEntry.state, flutterState);
       expect(strategy.currentEntry.url, '/home');
-    });
+    },
+        // TODO(nurhan): https://github.com/flutter/flutter/issues/50836
+        skip: browserEngine == BrowserEngine.edge);
   });
 }
 

diff --git a/lib/web_ui/test/engine/semantics/semantics_helper_test.dart b/lib/web_ui/test/engine/semantics/semantics_helper_test.dart
@@ -63,7 +63,9 @@ void main() {
           desktopSemanticsEnabler.tryEnableSemantics(event);
 
       expect(shouldForwardToFramework, true);
-    });
+    },
+        // TODO(nurhan): https://github.com/flutter/flutter/issues/50754
+        skip: browserEngine == BrowserEngine.edge);
 
     test(
         'Relevants events targeting placeholder should not be forwarded to the framework',
@@ -149,7 +151,7 @@ void main() {
     },
         // TODO(nurhan): https://github.com/flutter/flutter/issues/50590
         // TODO(nurhan): https://github.com/flutter/flutter/issues/46638
-        skip: (browserEngine == BrowserEngine.firefox ||
-            browserEngine == BrowserEngine.webkit));
+        // TODO(nurhan): https://github.com/flutter/flutter/issues/50754
+        skip: browserEngine != BrowserEngine.blink);
   });
 }